660536 - Useless uses of PromiseFlat(C)String

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[e-mail]]

There's no point calling PromiseFlat(C)String on known flat strings.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Pushed changeset b9dab5588ce1 to mozilla-central.

Comment 3

[(no longer active)]

Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz

Comment 4

[[e-mail]]

Not worth my while checking things in any more, some other loser can do it.

Comment 5

[[e-mail]]

Attachment: Updated for bitrot

Bug 660721 divergently renamed nsObjectFrame.cpp to nsPluginInstanceOwner.cpp

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to comment #5)
> Bug 660721 divergently renamed nsObjectFrame.cpp to nsPluginInstanceOwner.cpp

That means it made a copy of that file, I think.

It looks like you just changed your patch with s/nsObjectFrame.cpp/nsPluginInstanceOwner.cpp/, but presumably you *also* want to patch the original file (nsObjectFrame.cpp), right?

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to comment #6)
> It looks like you just changed your patch with
> s/nsObjectFrame.cpp/nsPluginInstanceOwner.cpp/, but presumably you *also*
> want to patch the original file (nsObjectFrame.cpp), right?

Ah, nevermind - while nsObjectFrame.cpp still exists, it no longer has the relevant chunk of code. (Bug 660721 deleted that chunk, along with creating the copy.)

Comment 8

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f68c52f253e7

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f68c52f253e7