660768 - modules should use mozilla::Preferences

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 536254 [details] [diff] [review]
Patch v1.0

Review of attachment 536254 [details] [diff] [review]:
-----------------------------------------------------------------

So imglib doesn't unregister its observers either? Would be nice to fix :-)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #1)
> So imglib doesn't unregister its observers either? Would be nice to fix :-)

Hmm... I have no idea to unregister it. Looks like imgRequest isn't singleton. The first instance registers an observer as strong. The observer is destroyed by nsPrefBranch at XPCOM shutdown. So, it doesn't make sense to remove the observer from its destructor.

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 536254 [details] [diff] [review]
Patch v1.0

Review of attachment 536254 [details] [diff] [review]:
-----------------------------------------------------------------

I like it!

::: modules/libpr0n/src/imgLoader.cpp
@@ +914,2 @@
>  {
> +  NS_ASSERTION(Preferences::GetRootBranch(), "Pref branch is null");

You could just drop this assertion entirely, IMO.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/3f771ec754bb

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Verified that the following files are updated un mozilla-central repository:
modules/libjar/nsJARChannel.cpp
modules/libpr0n/src/DiscardTracker.cpp
modules/libpr0n/src/imgLoader.cpp
modules/libpr0n/src/imgLoader.h
modules/libpr0n/src/imgRequest.cpp

Is this enough in order to verfy the fix and mark the bug accordingly?

Thank you!