Closed Bug 660799 Opened 13 years ago Closed 13 years ago

decodeURIComponent should throw URIError for '%ED%A0%80'

Categories

(Rhino Graveyard :: Core, defect)

Product:
Rhino Graveyard
Component:
Core
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: masa141421356, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

Improved patch
7.20 KB, patch
Details | Diff | Splinter Review
Test case
1.42 KB, patch
Details | Diff | Splinter Review 
Rhino seems to have same problem of bug 660612.
Severity: normal → minor
OS: Windows XP → All
Hardware: x86 → All
Blocks: 489326
Attached patch Patch v1 (obsolete) — — Splinter Review 
Ported from the final patch for bug #660612 for Spidermonkey. Also throws URIError on overlong UTF-8 sequences which should fix #660798. 

I'm not sure if there's anything else we need to port from Spidermonkey #511859 for recognizing overlong sequences.

Still needs update of tests (remove regress-172699.js, add regress-511859.js).
Attached patch Improved patch — — Splinter Review 
Make sure we always throw URIErrors in decode and encode functions, and remove obsolete test case.
Attachment #575637 - Attachment is obsolete: true
Attached patch Test case — — Splinter Review 

    
    

    
  
Committed and pushed to master:

https://github.com/mozilla/rhino/commit/879940b9f51be52c8a08f5e94ee9c81f590e2b07
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: