660879 - Create a temporary configure option to switch from the binary xpidl to pyxpidl

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch to add temporary configure option

I want to have pyxpidl in the tree side by side with the binary xpidl, so that I can unblock people who need pyxpidl but aren't that concerned about the build perf.  A configure option seems like the easiest way to do this.

This is 110% temporary.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 536332 [details] [diff] [review]
Patch to add temporary configure option

Review of attachment 536332 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1876,5 @@
>  fi
>  
>  dnl ========================================================
> +dnl xpidl - A temporary configure option for turning on pyxpidl
> +dnl ========================================================

File a followup bug on removing this and mention the bug number here please? Too many temporary things live on forever.

@@ +1889,5 @@
> +        XPIDL_COMPILE='$(LIBXUL_DIST)/host/bin/host_xpidl$(HOST_BIN_SUFFIX)'
> +    else
> +        XPIDL_COMPILE='$(LIBXUL_DIST)/bin/xpidl$(BIN_SUFFIX)'
> +    fi
> +    XPIDL_COMPILE_HEADER="$XPIDL_COMPILE -m header -w \$(XPIDL_FLAGS) -o \$(XPIDL_GEN_DIR)/\$*"

You can put these in single quotes to avoid bash eating your $s instead of escaping every single one.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Don't think we'll need this.