661091 - iQ.animate: only animate properties that are changing

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

>  this.css({
>    '-moz-transition-property': 'all', // TODO: just animate the properties we're changing
>    '-moz-transition-duration': (duration / 1000) + 's',
>    '-moz-transition-timing-function': easing
>  });

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Raymond Lee [:raymondlee]]

Comment on attachment 536531 [details] [diff] [review]
patch v1

Looks good

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 536531 [details] [diff] [review]
patch v1

r=sdwilsh

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/bcccd02b5294

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Backed out because this breaks sequential iQ.animate() calls. If we call .fadeIn() and then .setBounds() it interrupts the fading animation and starts the bounds animation.

Comment 6

[Philipp von Weitershausen [:philikon]]

Backed out the back out since it caused a Moth failure on Linux64 opt: http://hg.mozilla.org/integration/mozilla-inbound/rev/b4f654c5f999

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Re-marking as fixed.