661153 - Content process crashes don't display uptime

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Josh Matthews [:jdm]]

Example: https://crash-stats.mozilla.com/report/index/55a916c9-8e78-4fa4-89b2-1eeec2110528

Ted pulled the JSON from another similar crash, and both CrashTime and StartupTime are present: http://pastebin.mozilla.org/1240259

I'm absolutely certain that Uptime used to be displayed when I added StartupTime to content process crash dumps, so something must have regressed with Socorro since then.

Comment 1

[Josh Matthews [:jdm]]

Also, the list of multiple crashes displays uptime just fine: https://crash-stats.mozilla.com/report/list?range_value=7&range_unit=days&date=2011-06-01%2003%3A00%3A00&signature=nsWebSocketEstablishedConnection%3A%3AConsoleError&version=Fennec%3A7.0a1

Comment 2

[Robert Helmer [:rhelmer]]

Looks like the uptime for this crash is only 9 seconds:

https://crash-stats.mozilla.com/dumps/55a916c9-8e78-4fa4-89b2-1eeec2110528.jsonz

And for some reason the function returns an empty string if this value is under 3 minutes:

http://code.google.com/p/socorro/source/browse/trunk/webapp-php/application/libraries/timeutil.php#88

Simple fix would be to return seconds instead of empty string in this case; not sure what's so special about 3 minutes though (why not 1 minute?)

Comment 3

[Robert Helmer [:rhelmer]]

Ted points out this regressed here:
http://code.google.com/p/socorro/source/detail?r=2957&path=/trunk/webapp-php/application/views/report/index.php

The "ghetto_time_ago_in_words" time formatting function was not used here before then.

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: stop using "ghetto_time_ago_in_words"

also this function name annoys me greatly, but leaving that for a different bug :)

Comment 5

[Robert Helmer [:rhelmer]]

This is minor enough we should take for 1.7.8 (shipping tomorrow) assuming landing this on trunk doesn't cause anything to explode

Comment 6

[Brandon Savage [:brandon]]

Comment on attachment 536712 [details] [diff] [review]
stop using "ghetto_time_ago_in_words"

Review of attachment 536712 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a huge fan of necessarily backing the change out, but I think it's our lowest risk course of action with a ship date of less than 24 hours from now.

We'll file a bug to fix the underlying issue in the 2.0 release.

Comment 7

[Robert Helmer [:rhelmer]]

Filed bug to followup

Landed on trunk:
Committed revision 3185.

Going to make sure it looks ok on crash-stats-dev before landing on 178 branch.

Comment 8

[Robert Helmer [:rhelmer]]

Looks ok on crash-stats-dev (would be nice if it was formatted ;) but leaving that to followup):

Committed revision 3186.