661466 - Refactor utils.js clipboard flavors

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

// TODO: Move these (or similar) to jsutil/system/clipboardFlavors.js or
// something as part of bug 328878.

I actually want to do this as a prerequisite to bug 546170.

Two things:
1. Rename CSSDeclaration to CSSProperty.  Style declarations are not properties.  This probably contributed to the confusion in bug 536012 (comment 8).
2. Move it and DOMAttribute to jsutil/system/clipboardFlavors.js

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]

The license block stuff is based on these two changesets:
http://hg.mozilla.org/dom-inspector/rev/402a613487b6 (i.e., bug 338383)
http://hg.mozilla.org/dom-inspector/rev/0809873fb812 (i.e., bug 341256)

You can see that, besides me, those are the only two to have ever touched the code:
http://hg.mozilla.org/dom-inspector/annotate/7056acde111a/resources/content/utils.js#l178
http://hg.mozilla.org/dom-inspector/annotate/cac8571880ea/resources/content/utils.js#l193

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes [pushed in comment 4]

Comment 3

[[e-mail]]

Comment on attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]

Sorry for the delay. I don't have a trunk build that knows how to handle file copies but then I realised that my branch build pulls trunk inspector anyway.

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]

Pushed:
http://hg.mozilla.org/dom-inspector/rev/38f7c7d8867c
http://hg.mozilla.org/dom-inspector/rev/63179abb9bd5