661947 - Source viewer doesn't always wrap source code correctly, sometimes hiding code

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

In the included URL, if I select file chrome/content/ietabSetting1.js you should be able to see line 28 being wrapped because it's too long. However, it's also cropped.

The line is

gConsole: Components.classes["@mozilla.org/consoleservice;1"].getService(Components.interfaces.nsIConsoleService),

However, at least on my browser I don't see the last 5 characters in that line, and several other lines below. If the lines can't be reliably wrapped, then there should be some indication that there's more code to be seen. A scrollbar works.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Actually, there is a scrollbar, but it's so far to the bottom of the page that I didn't know it was there. The problem remains, though, there's no clear indication that I can scroll to the side in these cases, and ideally the source should be always wrapped to avoid any scrolling.

Comment 2

[Wil Clouser [:clouserw]]

We shouldn't be messing with scrollbars and stuff - if it's wrapped it should be wrapped.

Is this a bug with the JS or CSS?

Comment 3

[Andy McKay]

Using word-wrap: break-word which generally gets it close. I can set to not wrapped at by default.

Comment 4

[Andy McKay]

Set to unwrapped by default, I still think its a useful option so left the option to wrap there.

https://github.com/jbalogh/zamboni/commit/a73cd6a726c3331c3141e983ffc9450622880d24

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

This doesn't fix the problem. I still need to scroll down several pages (in many cases) just to reach the scrollbar. This is not very usable at the moment.

Comment 6

[krupa raj[:krupa]]

reopening as per comment 5

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> This doesn't fix the problem. I still need to scroll down several pages (in
> many cases) just to reach the scrollbar. This is not very usable at the
> moment.

Why is there a scrollbar if the text is wrapped?

Comment 8

[Andy McKay]

Because some long lines of code do not have any white space in them. After a certain amount of text without any white space Fx does not wrap them using word-wrap: break-word.

Comment 9

[Wil Clouser [:clouserw]]

That sounds like a pretty rare case.  Jorge - what are you picturing as a solution to this bug?

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

It's not so rare when we consider this is code, and not top quality code in many cases.

I see 2 possibilities:
1) Getting the line breaks right so that there's never any horizontal scrolling. That means that even lines without spaces need to break so that they don't leave the frame.
2) Have the horizontal scrollbar visible at all times. Likes most IDEs do, we can have a frame for the source viewer that always fits the screen.

Comment 11

[Andy McKay]

Attachment: Wrapping

Got it wrapping nicely. Here's a pathalogical test. Big speed up on calculating line numbers too.

Comment 12

[Andy McKay]

Back to wrapping.

https://github.com/jbalogh/zamboni/commit/dc2d429ef42e09d4921d93de2c3a79d314c9da3e 
https://github.com/jbalogh/zamboni/commit/cc31f91af68f5b48aae8edcc8dc6e71600b2daba

Should speed things up too.

Comment 13

[Wil Clouser [:clouserw]]

> Should speed things up too.

I think there is another bug about that

Comment 14

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...