Closed
Bug 661967
Opened 13 years ago
Closed 13 years ago
GCC 4.6 build warning: "nsIOService.cpp:432:12: warning: variable ‘listedProtocol’ set but not used"
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.24 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
When building with GCC 4.6:
{
netwerk/base/src/nsIOService.cpp:432:12: warning: variable ‘listedProtocol’ set but not used [-Wunused-but-set-variable]
}
From comparing these consecutive revisions...
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/src/nsIOService.cpp&rev=1.199
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/src/nsIOService.cpp&rev=1.200
...it looks like revision 200 (bug 391978) removed the last use of this variable.
Seems like we can just remove it completely now.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 537258 [details] [diff] [review] fix: remove variable Oops. The review comments in bug 391978 had even mentioned this.... r=me
Attachment #537258 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/d9c15147d35d
Whiteboard: [build_warning] → [build_warning][fixed-in-cedar]
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d9c15147d35d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed-in-cedar] → [build_warning]
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•