Closed
Bug 662155
Opened 13 years ago
Closed 13 years ago
addTab should report the exception when loadURIWithFlags fails
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 7
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
1021 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
See bug 662152 comment 2. A simplified testcase would be: gBrowser.addTab("http://bing.com", 0)
Attachment #537456 -
Flags: review?(gavin.sharp)
|
||
Updated•13 years ago
|
Attachment #537456 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/93911949517c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Can you please be more specific on how to verify this bug as being resolved fixed? thx
|
|
Assignee | |
Comment 3•13 years ago
|
||
Open the error console and execute this:
top.opener.gBrowser.addTab("http://bing.com", 0)
You should get an exception telling you that 0 is an invalid argument.Is this the exception mentioned? Error: [Exception... "Could not convert JavaScript argument - 0 was passed, expected object. Did you mean null? arg 2 [nsIWebNavigation.loadURI]" nsresult: "0x80570035 (NS_ERROR_XPC_BAD_CONVERT_JS_ZERO_ISNOT_NULL)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 193" data: no] Source File: chrome://browser/content/tabbrowser.xml Line: 1334
|
|
Assignee | |
Comment 5•13 years ago
|
||
yes...
You need to log in
before you can comment on or make changes to this bug.
Description
•