662224 - NS_ATTR_MALLOC and NS_WARN_UNUSED_RESULT not defined when mozalloc.h is indirectly included in embedding code

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

When building e.g. external binary xpcom components with mozalloc (which is supposedly the default), including nsISupports.h (which is necessary when you use your own interfaces) includes nscore.h which includes mozalloc.h. That leads to a failure to build, since NS_ATTR_MALLOC and NS_WARN_UNUSED_RESULT are not defined. They are defined in mozilla-config.h (which is included from nowhere), but it seems wrong to rely on the fact that the compiler used to build the component supports the same things as the compiler used to build the sdk.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Safeguard NS_ATTR_MALLOC and NS_WARN_UNUSED_RESULT in mozalloc.h

Comment 2

[Benjamin Smedberg]

Comment on attachment 537499 [details] [diff] [review]
Safeguard NS_ATTR_MALLOC and NS_WARN_UNUSED_RESULT in mozalloc.h

I think the correct thing to do here is add these to xpcom-config.h.in and include xpcom-config.h from this file.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Define NS_ATTR_MALLOC and NS_WARN_UNUSED_RESULT in xpcom-config.h, and include it from mozalloc.h

Comment 4

[Mike Hommey [:glandium]]

Attachment: Define NS_ATTR_MALLOC and NS_WARN_UNUSED_RESULT in xpcom-config.h, and include it from mozalloc.h.

As I'm going to land: we need to add $(DEPTH)/xpcom to the include path so that xpcom-config.h is found when building mozalloc, which is built before xpcom-config.h is copied into dist/bin.

Comment 5

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d959aeca8307

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d959aeca8307