Closed
Bug 662468
Opened 13 years ago
Closed 13 years ago
Android jsreftest-1 and jsreftest-2 mostly timing out mostly in e4x/Regress/regress-373082.js following June 6th TM merge
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: philor, Unassigned)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
1.18 KB,
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
Representative example in http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307400826.1307404228.31543.gz&fulltext=1#err0 - at some point in e4x/Regress/regress-373082.js (not the same point in all runs), it apparently drifts off to sleep, there's a section of httpd.js GC (which started filling up the Android logs with bug 508128), then a 2400 seconds without output timeout. So far since the merge, there have been 3 instances of this, 2 of an unrelated infra failure, and one passing run.
Reporter | ||
Comment 1•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307440246.1307443424.27331.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307434006.1307438439.7512.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307446426.1307450000.32711.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307428185.1307431265.9630.gz&fulltext=1
Reporter | ||
Comment 2•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307465207.1307468476.16449.gz&fulltext=1
Reporter | ||
Comment 3•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307474953.1307481468.4121.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307470426.1307476940.18014.gz&fulltext=1
Reporter | ||
Comment 4•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307567626.1307570930.23056.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307522205.1307527686.14993.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307497966.1307501943.16519.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307496225.1307499607.7225.gz&fulltext=1#err0
Reporter | ||
Comment 5•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307653066.1307657106.7968.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307636866.1307640774.10911.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307615266.1307618797.26004.gz&fulltext=1
Reporter | ||
Comment 6•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307661886.1307665696.11563.gz&fulltext=1
Reporter | ||
Comment 7•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307668370.1307671518.4809.gz&fulltext=1
Blocks: 661896
Summary: Android jstreftest-1 mostly timing out in e4x/Regress/regress-373082.js following June 6th TM merge → Android jsreftest-1 mostly timing out in e4x/Regress/regress-373082.js following June 6th TM merge
Reporter | ||
Comment 8•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307709726.1307713181.22053.gz&fulltext=1
Reporter | ||
Comment 9•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307724223.1307727334.17116.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307726086.1307729260.24875.gz&fulltext=1
Reporter | ||
Comment 10•13 years ago
|
||
Starting to think that regress-373082.js is just the most common, or maybe it's very long so it offers more opportunity to be the one running when it hits. These two are in ecma/Date/15.9.5.9.js and ecma/Expressions/11.7.1.js. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307722194.1307727575.18058.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307698665.1307702713.28087.gz&fulltext=1
Summary: Android jsreftest-1 mostly timing out in e4x/Regress/regress-373082.js following June 6th TM merge → Android jsreftest-1 mostly timing out mostly in e4x/Regress/regress-373082.js following June 6th TM merge
Reporter | ||
Comment 11•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307706428.1307710235.8033.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307726691.1307732158.3998.gz&fulltext=1 js1_8/regress/regress-384412.js
Summary: Android jsreftest-1 mostly timing out mostly in e4x/Regress/regress-373082.js following June 6th TM merge → Android jsreftest-1 and jsreftest-2 mostly timing out mostly in e4x/Regress/regress-373082.js following June 6th TM merge
Reporter | ||
Comment 12•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307581102.1307584262.16318.gz&fulltext=1
Comment 13•13 years ago
|
||
What's up with all the before ... after ... messages? Aren't they from gc ? Is there a stuck preference somewhere ?
Reporter | ||
Comment 14•13 years ago
|
||
They're from httpd.js doing gc, since bug 508128. I'm hoping that it's not a problem, other than being massively annoying in Android logs (particularly when it shows up in the middle of data: URIs in reftest logs).
Comment 15•13 years ago
|
||
I'm wondering if the successful deletion of Object.prototype.toString would cause reftest to stop responding? Would saving toString prior to the deletion and restoring it after the assigment to actual help? expect = 'TypeError: String.prototype.toString called on incompatible XML'; try { delete XML.prototype.function::toString; > var saveToString = Object.prototype.toString; delete Object.prototype.toString; actual = <a>TEXT</a>.toString(); > Object.prototype.toString = saveToString } catch(ex) { actual = ex + ''; } TEST(7, expect, actual);
Reporter | ||
Comment 16•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307730405.1307735982.19855.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307731426.1307734547.13758.gz&fulltext=1
Reporter | ||
Comment 17•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307731126.1307736830.23062.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307734791.1307737948.27662.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307738222.1307741378.13710.gz&fulltext=1
Reporter | ||
Comment 18•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307740566.1307747747.6145.gz&fulltext=1
Reporter | ||
Comment 19•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307744265.1307747518.5454.gz&fulltext=1
Reporter | ||
Comment 20•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307751363.1307755734.5064.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307749464.1307756258.6811.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307739351.1307754030.30789.gz
Reporter | ||
Comment 21•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307749606.1307757905.13697.gz
Reporter | ||
Comment 22•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307764852.1307768028.19096.gz
Reporter | ||
Comment 23•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307764851.1307769546.24158.gz&fulltext=1 We've apparently pretty much thoroughly broken it, I'm hiding it on mozilla-inbound.
Reporter | ||
Comment 24•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307796230.1307799813.17252.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307793306.1307797376.5841.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307777986.1307781598.28291.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307792566.1307796796.2728.gz
Reporter | ||
Comment 25•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307813517.1307817654.27878.gz
Reporter | ||
Comment 26•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307813537.1307818664.30530.gz
Reporter | ||
Comment 27•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307822145.1307825837.20984.gz
Reporter | ||
Comment 28•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307826068.1307829587.920.gz
Reporter | ||
Comment 29•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307843446.1307847109.19636.gz
Reporter | ||
Comment 30•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307847465.1307850932.30933.gz
Reporter | ||
Comment 31•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307878425.1307882885.16320.gz
Reporter | ||
Comment 32•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307880406.1307883904.21741.gz
Reporter | ||
Comment 33•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307898406.1307901476.25762.gz
Reporter | ||
Comment 34•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307905966.1307909230.15241.gz
Reporter | ||
Comment 35•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307932306.1307935669.25947.gz
Reporter | ||
Comment 36•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307964766.1307968728.23230.gz
Reporter | ||
Comment 37•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307961826.1307965423.5622.gz
Reporter | ||
Comment 38•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307984534.1307987753.7635.gz
Comment 39•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307993054.1308001948.29606.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1307999902.1308003422.4136.gz
Reporter | ||
Comment 40•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308002416.1308008352.24897.gz
Comment 41•13 years ago
|
||
Igor, ping comment 15 ?
Reporter | ||
Comment 42•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308005714.1308009653.30456.gz
Reporter | ||
Comment 43•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308015432.1308019112.3165.gz
Reporter | ||
Comment 44•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308022033.1308028432.8723.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308022597.1308026669.2052.gz
Reporter | ||
Comment 45•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308023954.1308027990.7403.gz
Reporter | ||
Comment 46•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307998874.1308028227.8146.gz
Reporter | ||
Comment 47•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308028992.1308032656.24642.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308026892.1308030163.15191.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308055452.1308060743.20763.gz
Reporter | ||
Comment 48•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308057178.1308062356.30008.gz
Reporter | ||
Comment 49•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308051913.1308055031.25300.gz
Comment 50•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308064872.1308069715.29836.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308064872.1308069203.28005.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308066012.1308069094.27675.gz
Reporter | ||
Comment 51•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308080881.1308085492.27375.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308079725.1308083529.19914.gz
Reporter | ||
Comment 52•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308086399.1308090310.13835.gz
Reporter | ||
Comment 53•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308086697.1308090620.15305.gz
Reporter | ||
Comment 54•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308110872.1308115024.19045.gz
Reporter | ||
Comment 55•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308106261.1308112741.10199.gz
Reporter | ||
Comment 56•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308112817.1308117106.27526.gz
Reporter | ||
Comment 57•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308117525.1308121042.11850.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308115438.1308119005.3617.gz
Reporter | ||
Comment 58•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308117358.1308121620.14705.gz
Reporter | ||
Comment 59•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308122520.1308126254.1930.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308143888.1308147432.19340.gz
Reporter | ||
Comment 60•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308137650.1308154365.17737.gz
Reporter | ||
Comment 61•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308184619.1308188641.31404.gz
Reporter | ||
Comment 62•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308177840.1308188651.31420.gz
Reporter | ||
Comment 63•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308196079.1308203113.23228.gz
Reporter | ||
Comment 64•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308200820.1308204360.28961.gz
Reporter | ||
Comment 65•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308226439.1308229922.19973.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308226439.1308232595.767.gz
Reporter | ||
Comment 66•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308206158.1308217263.19329.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308224819.1308228055.11229.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308221030.1308225086.26742.gz
Reporter | ||
Comment 67•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308229080.1308232651.972.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308221094.1308226925.5443.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308227522.1308231204.26422.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308206699.1308214084.5361.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308203698.1308210726.21235.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308213052.1308216129.14857.gz
Reporter | ||
Comment 68•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308234704.1308237894.30376.gz
Reporter | ||
Comment 69•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308241262.1308244734.27398.gz
Reporter | ||
Comment 70•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308250465.1308253631.1737.gz
Reporter | ||
Comment 71•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308254639.1308259125.24091.gz
Reporter | ||
Comment 72•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308249479.1308261625.1163.gz
Reporter | ||
Comment 73•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308260818.1308264333.13898.gz
Reporter | ||
Comment 74•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308262318.1308265930.20409.gz
Reporter | ||
Comment 75•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308264571.1308268301.29112.gz
Reporter | ||
Comment 76•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308263861.1308272593.13320.gz
Reporter | ||
Comment 77•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308269098.1308272836.14383.gz
Reporter | ||
Comment 78•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308294659.1308298033.14914.gz http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308306359.1308310818.9274.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308295852.1308299188.19457.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308312719.1308318453.16029.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308294898.1308298624.17547.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308311038.1308315225.31513.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308288898.1308292301.23828.gz
Reporter | ||
Comment 79•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308310559.1308313274.22922.gz
Reporter | ||
Comment 80•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308318986.1308322607.7764.gz
Reporter | ||
Comment 81•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308326339.1308329689.10704.gz
Reporter | ||
Comment 82•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308330773.1308334064.29703.gz
Reporter | ||
Comment 83•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308328763.1308334516.31742.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308330772.1308334637.32124.gz
Reporter | ||
Comment 84•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308332279.1308335362.3208.gz
Reporter | ||
Comment 86•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308335631.1308340591.26020.gz
Comment 87•13 years ago
|
||
Comment on attachment 540104 [details] [diff] [review] patch I think that code's supposed to throw, so putting that in a finally block would be better, if the patch actually does anything to address this.
Reporter | ||
Comment 88•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308335039.1308345083.11337.gz
Comment 89•13 years ago
|
||
Thanks Waldo. I'll try it on try.
Reporter | ||
Comment 90•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308345838.1308348949.25331.gz
Reporter | ||
Comment 91•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308354539.1308358000.27344.gz
Reporter | ||
Comment 92•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308360179.1308364309.21063.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308358979.1308363229.16425.gz
Updated•13 years ago
|
Attachment #540104 -
Flags: review?(igor)
Comment 93•13 years ago
|
||
try doesn't run jsreftests on android yet. philor is going to hide this until we get that resolved.
Comment 94•13 years ago
|
||
Comment on attachment 540104 [details] [diff] [review] patch > try > { > delete XML.prototype.function::toString; >+ var saveToString = Object.prototype.toString; > delete Object.prototype.toString; > actual = <a>TEXT</a>.toString(); >+ Object.prototype.toString = saveToString; > } > catch(ex) > { > actual = ex + ''; > } Waldo is right as we need to restore prototype in any case. So lets write this as: delete XML.prototype.function::toString; var xml = <a>TEXT</a>; var saveToString = Object.prototype.toString; delete Object.prototype.toString; try { actual = xml.toString(); } catch(ex) { actual = ex + ''; } finally { Object.prototype.toString = saveToString; } Note that the try covers only the part of the code that is expected to throw.
Comment 95•13 years ago
|
||
Attachment #540104 -
Attachment is obsolete: true
Attachment #540416 -
Flags: review?(igor)
Comment 96•13 years ago
|
||
Comment on attachment 540416 [details] [diff] [review] patch v2 Review of attachment 540416 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #540416 -
Flags: review?(igor) → review+
Comment 97•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/2ff6092157a5 leaving open as we don't know this was the issue.
Reporter | ||
Comment 98•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1308679224.1308682382.5597.gz&fulltext=1 REFTEST TEST-START | http://10.250.48.211:30091/jsreftest/tests/jsreftest.html?test=e4x/Regress/regress-373082.js REFTEST TEST-PASS | http://10.250.48.211:30091/jsreftest/tests/jsreftest.html?test=e4x/Regress/regress-373082.js | Section 1 of test - Simpler sharing of XML and XMLList functions item 1 REFTEST TEST-PASS | http://10.250.48.211:30091/jsreftest/tests/jsreftest.html?test=e4x/Regress/regress-373082.js | Section 2 of test - Simpler sharing of XML and XMLList functions item 2 REFTEST TEST-PASS | http://10.250.48.211:30091/jsreftest/tests/jsreftest.html?test=e4x/Regress/regressbefore 393216, after 389120, break 057ff000 (etc. etc.) command timed out: 2400 seconds without output, killing pid 12122
Comment 99•13 years ago
|
||
(In reply to comment #93) > try doesn't run jsreftests on android yet. philor is going to hide this > until we get that resolved. Filed bug#666647 to get jsreftests on android enabled in TryServer.
Comment 100•13 years ago
|
||
(In reply to comment #94) > Comment on attachment 540104 [details] [diff] [review] [review] > patch > > > try > > { > > delete XML.prototype.function::toString; > >+ var saveToString = Object.prototype.toString; > > delete Object.prototype.toString; > > actual = <a>TEXT</a>.toString(); > >+ Object.prototype.toString = saveToString; > > } > > catch(ex) > > { > > actual = ex + ''; > > } > > > Waldo is right as we need to restore prototype in any case. So lets write > this as: > > delete XML.prototype.function::toString; > var xml = <a>TEXT</a>; > var saveToString = Object.prototype.toString; > delete Object.prototype.toString; > try { > actual = xml.toString(); > } catch(ex) { > actual = ex + ''; > } finally { > Object.prototype.toString = saveToString; > } > > Note that the try covers only the part of the code that is expected to throw. Has this patch landed in m-c yet? I ask because I see later reports of continues problems, but cant tell if this fix landed yet or not.
Comment 101•13 years ago
|
||
(In reply to comment #100) > Has this patch landed in m-c yet? I ask because I see later reports of > continues problems, but cant tell if this fix landed yet or not. No, but the problem still persists on tracemonkey where it did land.
Comment 102•13 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/2ff6092157a5 Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.
Comment 103•13 years ago
|
||
Is this still happening, or did bug 668594 fix it?
Comment 104•13 years ago
|
||
that bug landed on 07-09 (4 days ago) on mozilla-central. I would say this is fixed, and if we see issues we can reopen. If y'all agree, change the status.
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•