Closed
Bug 662649
Opened 13 years ago
Closed 13 years ago
Fixup fps display
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox7 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
2.33 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
This fixes a couple of problems: 1. switches to a 32 bit type 2. adds a bit of documentation 3. frees the temporary buffer
Attachment #537881 -
Flags: review?(joe)
Updated•13 years ago
|
Attachment #537881 -
Attachment is patch: true
Attachment #537881 -
Attachment mime type: text/x-patch → text/plain
Comment 1•13 years ago
|
||
Comment on attachment 537881 [details] [diff] [review] Fix up fps code. Review of attachment 537881 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/opengl/LayerManagerOGL.cpp @@ +575,5 @@ > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, > }; > > + // convert from 8 bit to 32 bit so that we don't have to write the text out in 32 bit format > + // we rely on int being 32 bits */ please remove trailing */
Attachment #537881 -
Flags: review?(joe) → review+
Updated•13 years ago
|
Assignee: nobody → jmuizelaar
Assignee | ||
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3b95f57892ba and children
status-firefox7:
--- → fixed
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 3•13 years ago
|
||
> Fix up fps code.
>
> This fixes a couple of problems:
>
> 1. switches to a 32 bit type
> 2. adds a bit of documentation
> 3. frees the temporary buffer
What is "fps"? First-person shooter?
I assume the temporary buffer was being leaked? How big is it, how often was it being leaked?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•13 years ago
|
||
"fps" is "Frames per second." This code lets us monitor how quickly we're drawing to the screen. It's not on by default, and, unless I am misremembering, before Jeff's changesets, it wasn't even possible to turn it on. Did you have any reason to reopen this?
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•13 years ago
|
||
We only leaked when a pref was set.
Comment 6•13 years ago
|
||
(In reply to comment #4) > > Did you have any reason to reopen this? It wasn't resolved, so I resolved it, but then I got cold feet because the link in comment 2 didn't seem to include the extra free() call that the attached patch did. But I guess it went in in one of the changes not listed?
Comment 7•13 years ago
|
||
I was trying to see if this is fixed for Fx7 since the flag "status-firefox7" is set to "fixed", but I couldn't. Is there a test case or any steps / guidelines for this bug that can be used to verify the fix? Thanks
You need to log in
before you can comment on or make changes to this bug.
Description
•