662898 - Canvas regression: Cannot draw image into canvas

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mark D.]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0

Cannot get canvas from canvas A, and draw it as an image into canvas B.

Reproducible: Always

Steps to Reproduce:
1. Visit http://radikalfx.com/files/collage/demo.html
2. Click search button on the bottom left
3. Click on an image

Actual Results:  
Image is not loaded into the canvas, instead there is an empty rectangle

Expected Results:  
Image is loaded into the canvas

Does not work in Firefox 5, or Firefox 7.0a1.
Works in Firefox 4.0.1, Safari, and Google Chrome

Comment 1

[Alice0775 White]

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/0798b52bb40d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110324 Firefox/4.2a1pre ID:20110324144234
Fails:
http://hg.mozilla.org/mozilla-central/rev/6a95db826e08
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110324 Firefox/4.2a1pre ID:20110324145508
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0798b52bb40d&tochange=6a95db826e08

Comment 2

[Alice0775 White]

FYI,
Toggle shadow off, then the image appears,

Comment 3

[Alice0775 White]

Bisected in local build,
Triggered by:
a34fe4ee349a	Robert O'Callahan — Bug 639689. Part 3: Remove unnecessary full context save/restore, and redundant SetPattern call. r=joe

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'll write a test for this when my tree is in a better state.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e01a18d61dd6

Once this lands on central, I would like to get it into ff5/beta if possible.

Comment 8

[Philipp von Weitershausen [:philikon]]

Backed out on m-i due to test_canvas.html failures:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d1b0a500fbf

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix test failure

We need to make sure the input pattern is set correctly when we draw the shadow.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a858cef629f0
http://hg.mozilla.org/integration/mozilla-inbound/rev/70c1c696f691

I pushed the test on the assumption it will be OK. If Jeff doesn't like it we can change it later.

Comment 11

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/a858cef629f0
http://hg.mozilla.org/mozilla-central/rev/70c1c696f691

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 538795 [details] [diff] [review]
fix test failure

Probably too late for beta, but might as well draw the attention of release drivers.

This is a canvas regression in an edge case, but the fix is very simple.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 538795 [details] [diff] [review]
fix test failure

too late for beta. we'll evaluate for 6.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e160897167a6
http://hg.mozilla.org/releases/mozilla-aurora/rev/3a6e0d66dc47

Comment 17

[dickvl]

Bug 668742 is about that this issue is still present in the current Firefox 5 release.

Can we expect any improvement in a Firefox 5 update or do we need to wait until Firefox 6 is released?

Then I know what to tell to people on he support forum that have this problem in Firefox 5.

You can see a list of support threads that show this problem in Firefox 5, so we can expect to see a lot more reports about this issue.

(cross posting this in bug Bug 668742  as this bug is resolved)

Comment 18

[Boris Zbarsky [:bzbarsky]]

> Can we expect any improvement in a Firefox 5 update or do we need to wait until > Firefox 6 is released?

Most likely the latter.  That should happen in mid-August....

Comment 19

[dickvl]

Thanks for confirming that.
I was already expecting that (porting code to another branch is not easy), but a confirmation helps to avoid confusion and disappointment.

Comment 20

[Boris Zbarsky [:bzbarsky]]

It's not just porting; there are just no plans to do any Firefox 5 updates before Firefox 6 ships unless a critical issue comes up; if one does an update would contain a fix for just that issue.

Once Firefox 6 ships, it becomes the security update to Firefox 5, with automatic updates from 5 to 6.

Comment 21

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified on Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 using the STR from the description. Image is now loaded and can be dragged into the canvas.

Setting resolution to VERIFIED FIXED.