663104 - Livemarks status menuitems are incorrectly updated

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Minor patch while I was looking at livemarks service.  This partly regressed in bug 387138, but partly was just unimplemented.
I don't think this needs a test, it's a minor and barely visible part, actually I think would even be better to rather use the livemark icon to show status (a throbber for loading, a broken livemark feed for loadfailed) rather than keeping this code. Btw let's fix what we have for now.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/projects/places/rev/40496d9e675f

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/40496d9e675f

Comment 3

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Can anyone please say what is expected to be seen after this fix or help me with a test case or with STR/guidelines in order to get this issue checked on QA side? 
Thanks!

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

So, when right clicking a livemark menu and doing Reload Live bookmark it should briefly appear in the menu a Live bookmark Loading... graytext entry. It should diappear almost immediately (unless the webpage is really slow), should not stick in the menu. Before this fix it was not appearing at all.

when a livemark fails the Live bookmark failed menuitem should stick, and disappear at the first successful reload. I suppose that you may simulate this by unplugging from network and reloading. Before this fix it was sticking in the menu even after a successful reload.

Comment 5

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified issue on Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6. using the following STR:
1. Right click on a livemark and from the context menu select Reload Live Bookmark  - "Live Bookmark Loading" gray text message briefly appears in the menu and then disappears (after loading completed).
2. Unplug the network connection and reload - "Live Bookmark feed failed to load" gray text message appears and then disappears (after enabling the network connection and reloading the livemark bookmark).

Livemark status is now correctly updated - Setting resolution to VERIFIED FIXED.