663136 - Add test coverage for tablist as implicit live region

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Noticed this just now during W3 call. Trivial patch coming.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 538268 [details] [diff] [review]
patch

r=me with this question answered/fixed:

>+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>

Any reason you didn't give that child a role of "tab"? Was that intentional? If so, why?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #2)
> Comment on attachment 538268 [details] [diff] [review] [review]
> patch
> 
> r=me with this question answered/fixed:
> 
> >+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>
> 
> Any reason you didn't give that child a role of "tab"? Was that intentional?
> If so, why?

Intentional. Leaving it off made it explicit that it didn't matter what the child was. I think if we later require the children to be tabs for the container-foo to work we should test for, and absence of, role=tab on the child. Make sense?

Comment 4

[Marco Zehe (:MarcoZ)]

Perfect, thanks!

Comment 5

[Trevor Saunders (:tbsaunde)]

landed http://hg.mozilla.org/mozilla-central/rev/4436b2bc5f64