663194 - Calling drawImage with zero-size canvas should throw INVALID_STATE_ERR

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

We currently throw INDEX_SIZE_ERR.

http://www.w3c-test.org/html/tests/approved/canvas/2d.drawImage.zerocanvas.html

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 538322 [details] [diff] [review]
Patch v1

Review of attachment 538322 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/public/nsHTMLCanvasElement.h
@@ +70,5 @@
>  
> +  static nsHTMLCanvasElement* FromContent(nsIContent* aPossibleCanvas)
> +  {
> +    if (!aPossibleCanvas || !aPossibleCanvas->IsHTML(nsGkAtoms::canvas)) {
> +      return NULL;

nsnull

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/8b3315430b6d

Comment 3

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Can anyone please tell me what is expected to be seen in the test case attached in the Description? I am trying to verify this on the QA side and by loading the test example I get a green background, 2 red bordered rectangles and a "Pass" result bellow them.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Correct.

Comment 5

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified on Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 - loading the test example from the Description gives me a green background and a "Passed" result.

Setting resolution to VERIFIED FIXED.

Thanks Ms2ger!