663302 - Contribute pop-up on add-on page is off-screen

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[tofumatt [:tofumatt]]

Attachment: Screenshot of misaligned contribute popover form

Clicking the "<3 Contribute" link activates a popover, but it appears (partially) off-screen, then jumps around when closed (by click anywhere on the page it isn't occupying). This is happening on addons.allizom.org on Aurora for Mac (6.0.2a).

Steps:

1. Go to https://addons.allizom.org/z/en-US/firefox/addon/tineye-reverse-image-search/contribute/roadblock/?src=creatured&version=1.1
2. Click on the <3 Contribute link
3. Wonder where the popover went!

Expected result:

The popover appears entirely within the browser's viewport (centered).

Actual result:

The popover appears partially out-of-view and cannot be used.

Attached is a screenshot of the actual result.

Comment 1

[krupa raj[:krupa]]

note: This is on 6.0a2

Comment 2

[Wil Clouser [:clouserw]]

I can reproduce in a nightly on linux.

Comment 3

[Potch [:potch]]

Andy, depending on the funkiness at play here, you can try switching the contribute modal from the current jquery modal to the modal we have in zamboni/global.js- it seems to be working well in Nightly. It also means we get one step closer to throwing that jqm library out!

Comment 4

[Andy McKay]

Didn't read comment-3 until after, but yes we should be using that.

Comment 5

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/6f3e8b29b3aa9d4977dcfb3c8dfbbf52619636e8

Bug filed to remove jqmWindow.

Comment 7

[krupa raj[:krupa]]

verified at https://addons-next.allizom.org/en-US/firefox/addon/tineye-reverse-image-search/contribute/roadblock/?src=creatured&version=1.1

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot