Closed Bug 663472 Opened 13 years ago Closed 13 years ago

Any page with a "test" button on it doesn't validate

Categories

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Builder
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Builder 0.9.6

People

(Reporter: rfreebern, Assigned: rfreebern)

References

(
URL
)

Details

The HTML generated for the add-on "Test" button includes a rel="jid..." attribute that is invalid. This affects the homepage, the search results page, the user dashboard, etc.

See http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2F for an example.

A suggested solution is to use a data-jetpackid attribute instead.
Assignee: nobody → ryan
Sean gave me some feedback and I found another affected file, which is covered by https://github.com/rfreebern/FlightDeck/commit/24f8c5cde152b54b323c89b8f59aca786a129d4c

All other instances of rel attributes in the code are unrelated to the test buttons.
Fixed by https://github.com/mozilla/FlightDeck/commit/95d3d23e7fe8a03d0b7165274f17399d63c28282
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.