663586 - Unable to restore window by clicking taskbar button after minimize from fullscreen, Unable to restore normal window by F11 from fullscreen after minimizing from fullscreen

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/1619d8fc6416
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110610 Firefox/7.0a1 ID:20110610030736


Unable to restore window by clicking taskbar button after minimizing from fullscreen.

Unable to restore normal window by F11 from fullscreen after minimizing from fullscreen once.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox with new profile --- Now Normal mode
2. F11
3. Click Minimize button at the top-right corner.
4. Click Taskbar button.

Actual Results:
 Nothing happens
 

Expected Results:
 Restore window in Fullscreen


Steps to Reproduce:
1. Start Firefox with new profile --- Now Normal mode
2. F11
3. Click Minimize button at the top-right corner.
4. F11
5. Click Restore button at the top-right corner.

Actual Results:
  after Step4 : Restore fullscreen.
  after Step5 : Minimized 
 
Expected Results:
  after Step4 : Nothing happen.
  after Step5 : Restore window in Normal mode or Maximized mode(if Maximize in step1)) if Step4 is correct behavior.

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/b8c7dd3bddbc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110527 Firefox/7.0a1 ID:20110527153216
Fails:
http://hg.mozilla.org/mozilla-central/rev/dc1077c09540
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110527 Firefox/7.0a1 ID:20110527153902
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b8c7dd3bddbc&tochange=dc1077c09540
Regressen by:
dc1077c09540	Jim Mathies — Bug 580564 - Fix for broken alt-space sys menu restore when in full screen mode. r=neil

CC'ing:
Jim Mathies, neil

Comment 1

[Jim Mathies [:jimm]]

confirmed, I can reproduce.

Comment 2

[Jim Mathies [:jimm]]

I've been mucking around with this for a bit but haven't found a good solution. Our size mode tracking in widget is a bit tricky - when callers set the size mode we wait and update mSizeMode after the transition occurs. Things get out of sync when we dispatch a size mode event that triggers the SetFullScreen call on global window.. which triggers additional widget calls that change the size mode again.

I'm going to back out the changes in bug 580564 and re-open that bug (and close this one).