Closed Bug 663646 Opened 13 years ago Closed 13 years ago

intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js | title starts with 'title' - Got -1, expected 0

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 7

People

(Reporter: mbrubeck, Assigned: ttaubert)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

patch v2 (diagnostic)
1016 bytes, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307813882.1307815856.22257.gz

INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug594958.js | finished in 977ms
TEST-INFO | checking window state
TEST-INFO | before wait for focus -- loaded: complete active window: ([object ChromeWindow]) chrome://browser/content/browser.xul focused window: ([object ChromeWindow]) chrome://browser/content/tabview.html desired window: ([object ChromeWindow]) chrome://browser/content/browser.xul child window: ([object XrayWrapper [object Window]]) about:blank docshell visible: true
TEST-INFO | must wait for focus
TEST-INFO | waitForEvent called <type:focus, target[object XrayWrapper [object HTMLDocument]]> -- loaded: complete active window: ([object ChromeWindow]) chrome://browser/content/browser.xul focused window: ([object XrayWrapper [object Window]]) about:blank desired window: ([object ChromeWindow]) chrome://browser/content/browser.xul child window: ([object XrayWrapper [object Window]]) about:blank docshell visible: true
TEST-INFO | maybe run tests <load:true, focus:true> -- loaded: complete active window: ([object ChromeWindow]) chrome://browser/content/browser.xul focused window: ([object XrayWrapper [object Window]]) about:blank desired window: ([object ChromeWindow]) chrome://browser/content/browser.xul child window: ([object XrayWrapper [object Window]]) about:blank docshell visible: true
TEST-START | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js | title starts with 'title' - Got -1, expected 0
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js | Console message: [JavaScript Error: "mismatched tag. Expected: </b>."]
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js | title starts with 'new-title'
Blocks: 660175
Adding intermittent test failures to new meta bug.

(bugspam)
Blocks: 665844
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attached patch patch v1 (obsolete) — — Splinter Review 
I suppose that this test intermittently fails because it calls .getWindowTitleForBrowser() before the delayed browser startup is finished (so TabView.init() hasn't been called yet). In this case TabView.getActiveGroupName() just returns null.
Attachment #541013 - Flags: feedback?(raymond)
Comment on attachment 541013 [details] [diff] [review]
patch v1

Looks good!
Attachment #541013 - Flags: feedback?(raymond) → feedback+
Attachment #541013 - Flags: review?(ehsan)
Attachment #541013 - Flags: review?(ehsan) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/471e9be56f37
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange], [inbound] → [orange]
Target Milestone: --- → Firefox 7
not fixed yet

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1309417896.1309419710.752.gz
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug595020.js | title starts with 'title' - Got -1, expected 0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I currently have no idea why this test is failing and added a line that outputs the current windowTitle before checking it. I'd like to see if this is related to bug 669168 (i.e. there could be a character missing?!).
Attachment #541013 - Attachment is obsolete: true
Attachment #544433 - Flags: review?(ehsan)
Comment on attachment 544433 [details] [diff] [review]
patch v2 (diagnostic)

FWIW, you have blanket r+ from me for diagnostic patches in panorama in order to investigate intermittent oranges.  :)
Attachment #544433 - Flags: review?(ehsan) → review+
bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)
No longer blocks: 660175
Depends on: 682996
Fixed by bug 682996.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: