Closed Bug 663784 Opened 13 years ago Closed 13 years ago

gfxWindowsPlatform.cpp doesn't compile without D2D

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(2 files)

fix v1.0
791 bytes, patch
masayuki
: review+
Details | Diff | Splinter Review
Fix using statement
1.72 KB, patch
masayuki
: review+
Details | Diff | Splinter Review
Attached patch fix v1.0 — — Splinter Review 
      No description provided.
Attachment #538863 - Flags: review?(masayuki)
Component: GFX: Color Management → Graphics
Comment on attachment 538863 [details] [diff] [review]
fix v1.0

Oh, thanks!
Attachment #538863 - Flags: review?(masayuki) → review+
QA Contact: color-management → thebes
Thanks for review, pushed to inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/e363e219a4b8
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/e363e219a4b8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
We don't put using statements before includes.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh, right. The attached patch fixes using statement. Previous code also had includes after using statement, this patch fixes that as well. It also removes WINCE code.
Attachment #539773 - Flags: review?(masayuki)
Attachment #539773 - Flags: review?(masayuki) → review+
Pushed to inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/1fc165fdfa07
Whiteboard: [inbound]
Merged to m-c:
http://hg.mozilla.org/mozilla-central/rev/1fc165fdfa07
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: