663879 - Kill AddEventListenerByIID/RemoveEventListenerByIID from extensions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

I checked all code paths called by HandleEvent and they always QI and bail if the event doesn't implement the desired interface.

Still running this through tryserver, as it seems like some of this code is platform dependent, so not asking for review yet.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

The previous patch lacked adjustments to the QI implementations. This one seems to be passing tryserver.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 538974 [details] [diff] [review]
Patch to fix


> NS_IMETHODIMP mozInlineSpellChecker::HandleEvent(nsIDOMEvent* aEvent)
> {
>+  nsAutoString eventType;
>+  aEvent->GetType(eventType);
>+
>+  if (eventType.EqualsLiteral("blur"))
>+    return Blur(aEvent);
>+  if (eventType.EqualsLiteral("click"))
>+    return MouseClick(aEvent);
>+  if (eventType.EqualsLiteral("keypress"))
>+    return KeyPress(aEvent);

Coding style is:
if (expr) {
  stmt;
}


>+  if (eventType.EqualsLiteral("mousedown"))
>+    return MouseDown(aEvent);
>+  if (eventType.EqualsLiteral("mouseup"))
>+    return MouseUp(aEvent);
>+  if (eventType.EqualsLiteral("mousemove"))
>+    return MouseMove(aEvent);

if (expr) {
  stmt;
}

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in to m-c:
http://hg.mozilla.org/mozilla-central/rev/967b254211be

Thanks for the review!

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Aww, crap, this wasn't the one I intended to land. This depends on bug 663461.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Landed http://hg.mozilla.org/integration/mozilla-inbound/rev/ab2e92a211e1

Thanks for review!

Comment 6

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/ab2e92a211e1