664083 - warning in nsHTMLTableAccessible.cpp:325

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Trevor, please give a warning message, otherwise it may be hard to understand what you fix here.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 539134 [details] [diff] [review]
patch

Review of attachment 539134 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLTableAccessible.cpp
@@ +321,1 @@
>  

I'd suggest to use enum (you should give it a name) instead PRInt32 and do
PRUint32 headerRole = aRowOrColumnHeaderCell == nsAccUtils::eRowHeaderCells ?
nsIAccessibleRole::ROLE_ROWHEADER : nsIAccessibleRole::ROLE_COLUMNHEADER;

Comment 4

[Trevor Saunders (:tbsaunde)]

(In reply to comment #3)
> Comment on attachment 539134 [details] [diff] [review] [review]
> patch
> 
> Review of attachment 539134 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/html/nsHTMLTableAccessible.cpp
> @@ +321,1 @@
> >  
> 
> I'd suggest to use enum (you should give it a name) instead PRInt32 and do
> PRUint32 headerRole = aRowOrColumnHeaderCell == nsAccUtils::eRowHeaderCells ?
> nsIAccessibleRole::ROLE_ROWHEADER : nsIAccessibleRole::ROLE_COLUMNHEADER;

yeah, that would be nice.  I was thinking about  changing the parameter to an enum  and returning  a pointer to the array instead of the out param in bug 648265.  How does that sound?

Comment 5

[alexander :surkov (:asurkov)]

not sure how you treat "a pointer to the array" but array as return value vs out argument is fine with me.

Comment 6

[Trevor Saunders (:tbsaunde)]

landed http://hg.mozilla.org/mozilla-central/rev/b06efa3e0073

Comment 7

[Trevor Saunders (:tbsaunde)]

landed http://hg.mozilla.org/mozilla-central/rev/06c3225b1656