664123 - "ASSERTION: Why don't we have a document type node?" and null deref

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

###!!! ASSERTION: Why don't we have a document type node?: 'docType1 && docType2', file content/base/src/nsGenericElement.cpp, line 905

Regression from somewhere in here:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4e1b20229d4d&tochange=1b11c64ffcd

Comment 1

[Jesse Ruderman]

Attachment: stack trace for the assertion

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/f4ff8d137c1f

   5.110 +        nsCOMPtr<nsIDOMDocumentType> docType1 = do_QueryInterface(this);
   5.111 +        nsCOMPtr<nsIDOMDocumentType> docType2 = do_QueryInterface(aOther);

This is bogus...

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Why was this cause for backing out all of the original patches?

Comment 4

[Boris Zbarsky [:bzbarsky]]

So this is fixed now, right?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, by updated patches in bug 659053