664321 - Cannot edit Demo Studio demos

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[John Karahalis [:openjck]]

Jay has reported that he cannot edit Demo Studio demos. He can click the "Edit" button that he sees and edit the demo as normal, but when he clicks "Save" he sees an Internal Server Error.

We are not sure if / how this affects users.

* Can users edit their own demos?
* Can users submit demos?

Comment 1

[John Karahalis [:openjck]]

Because of this, administrators cannot manually add existing demos to the Dev Derby.

Comment 2

[Les Orchard [:lorchard]]

(In reply to comment #1)
> Because of this, administrators cannot manually add existing demos to the
> Dev Derby.

Which demo(s) in particular? I was able to edit a few successfully.

Comment 3

[John Karahalis [:openjck]]

Jay was having trouble with the "Fly-in Form" demo, but I see that it is now listed on the Dev Derby page.

https://developer.mozilla.org/en-US/demos/detail/fly-in-form

Comment 4

[Les Orchard [:lorchard]]

(In reply to comment #3)
> Jay was having trouble with the "Fly-in Form" demo, but I see that it is now
> listed on the Dev Derby page.
> 
> https://developer.mozilla.org/en-US/demos/detail/fly-in-form

Hmm... I could edit that one too, added and removed a tag. Not sure what might have happened there.

Comment 5

[John Karahalis [:openjck]]

Jay noticed that his settings were saved when he hit the "Save" button, despite the 500 error. This might explain why the demo is showing up on the Dev Derby site after all.

Comment 6

[Jay Patel [:jay]]

les:  the bug summary might be misleading... here is what i did:

1. on demo details page, i clicked the edit demo button, checked the dev derby box and clicked save.
2. got an ISE 500 (didn't verify if the changes stuck)
3. went to django admin, added the tag manually and saved
4. noticed the demo was now in dev derby

------------

then i tried to test changing something else... 

1. open demo details page, edit, changed title of demo, save
2. got an ISE 500
3. the name change stuck... even with the error

so it looks like i get an ISE when i try to save an existing demo through the MDN ui... but the changes are preserved. 

not sure why i get the 500 error... which is what this bug is really about.

anyone else see a 500 error when editing an existing demo and trying to save?

Comment 7

[Les Orchard [:lorchard]]

Steps to reproduce helped, thanks. The admin pages work fine, it's the general site UI that throws an error on edit. Definitely a bug, and I just pushed a fix:

https://github.com/mozilla/kuma/commit/9f01d6af25b624a8a0fc3f26d59f45f1502a367e

Need to get more tests wrapped around this stuff, ugh.

Comment 8

[Les Orchard [:lorchard]]

For good measure, added tests to make sure demo editing works:

https://github.com/mozilla/kuma/commit/56e55702a269d4b8c0d817a1a896c30bb27833bc