664376 - table rows of XUL trees no longer containing cell content as accessible name

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

STR:
1. Open about:config.
2. Inspect the table.

Expected: The row accessibles should contain an accessible name consisting of all the string values of the cells below them.
Actual: They're empty now.

This is a regression from bug 546812, which was supposed to only fix the accessible name propagation from the tree container to the individual rows, but should not have broken name calculation from the cells up to the row.

Comment 1

[Marco Zehe (:MarcoZ)]

A direct result is that, when arrowing up and down through the table, NVDA no longer reads the currently selected item.

Comment 2

[alexander :surkov (:asurkov)]

changing summary to better reflect the bug (otherwise it sounds like tree tables are affected too)

Comment 3

[alexander :surkov (:asurkov)]

though actually we want to have rows of tables and tree tables for XUL trees to expose name as cell name concatenation (Marco filed bug 664384 to deprecate this approach in the future).

Comment 4

[Trevor Saunders (:tbsaunde)]

Surkov, where you planing on working on this soon?  I think this probably causes a bit of pain in nvda, or atleast will when it gets to something other than nightly, and I noticed that I couldn't check that the fix for bug 659018  actually worked because orca nolonger reads anything in the message view in thunderbird.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 542729 [details] [diff] [review]
patch

r=me, thanks!

Comment 7

[Trevor Saunders (:tbsaunde)]

pushed to try with 666504 606085  666337  429642   667396 as http://tbpl.mozilla.org/?tree=Try&rev=dbf9bbf7adc9

Comment 8

[Trevor Saunders (:tbsaunde)]

landed http://hg.mozilla.org/mozilla-central/rev/3b60b16fce55