664512 - Can't upload attachments: files[f].fileName is undefined

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Wil Clouser [:clouserw]]

To reproduce:

1) https://builder-addons.allizom.org/addon/1000134/latest/
2) Click [+] next to Data
3) Pick a file and click upload

See this in error console:
Error: files[f].fileName is undefined
Source File: https://builder-addons.allizom.org/media/jetpack/js/Sidebar.js
Line: 541


I'm using a nightly

Comment 1

[Wil Clouser [:clouserw]]

This works in fx 4.0.1

Comment 3

[Sean McArthur [:seanmonstar]]

This still happening in the nightlies?

Even if so, this is a browser bug...

Comment 4

[Wil Clouser [:clouserw]]

I think we concluded the browser API changed

Comment 5

[Sean McArthur [:seanmonstar]]

If this is the case, I'll need a link to the new API.

https://developer.mozilla.org/en/DOM/FileList currently says:

// loop trough files
for (var i = 0; i < files.length; i++) {

    // get item
    file = files.item(i);
    //or
    file = files[i];

    alert(file.name);
}

Comment 6

[Sean McArthur [:seanmonstar]]

ok, this has been changed in master.

apparently, Fx7 is dropping support for it's non-standard .fileName property of files. We now access the standard .name property.

https://github.com/mozilla/FlightDeck/commit/e7d142777e99317961e7ed69777585bde9edfecc

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using both Firefox 5, and nightlies on Windows/Mac.