Closed
Bug 664670
Opened 13 years ago
Closed 13 years ago
imageDataCb passed to Storage.getTabData in TabItem__reconnect runs when the tab is already gone
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 8
People
(Reporter: dao, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
dao
:
review+
raymondlee
:
feedback+
|
Details | Diff | Splinter Review |
Seen in browser-chrome test logs:
JavaScript Error: "self.tab is null" {file: "chrome://browser/content/tabview.js" line: 5178}
|
Assignee | |
Comment 1•13 years ago
|
||
I'd like to have checked in ThumbnailStorage.loadThumbnail() whether the given tab is still linked to a TabItem before executing the callback but that's not possible as the tab might have been re-used be SS/SR in the meantime. So we need to check if the TabItem is still linked to a tab in TabItem._reconnect();
|
||
Updated•13 years ago
|
Attachment #544619 -
Flags: feedback?(raymond) → feedback+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #544619 -
Flags: review?(dao)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 544619 [details] [diff] [review] patch v1 I don't think there's a point in checking tabData before self.tab.
Attachment #544619 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/fx-team/rev/3c57112a6a6f
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3c57112a6a6f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•