664860 - Rename several WebSockets classes/IDLs to match necko conventions before we ship WS

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect)

Description

[Jason Duell]

Right now the network transport for Web sockets is called nsIWebSocketProtocol.idl, and it's implemented by the nsWebSocketHandler class.

Everywhere else in necko we reserve "Protocol" and "Handler" for singleton, protocol-wide classes (see nsHttpHandler, nsFtpProtocolHandler, both of which inherit from nsIProtocolHandler.idl).  So this is needlessly confusing.

We should rename 

   nsIWebSocketProtocol -> nsIWebSocketChannel
   nsWebSocketHandler   -> WebSocketChannel

I'd especially like to see the IDL change before we ship WS for the first time, so we don't need to break XPCOM interfaces.

Comment 1

[Jason Duell]

Attachment: renames test_ws_basic_tests.html -> test_websocket_basic.html

Comment 2

[Jason Duell]

Attachment: renames sIWebSocketHandler => nsIWebSocketChannel

Comment 3

[Jason Duell]

Attachment: nsWebSocketHandler_to_WebSocketChannel

E10s classes are already named WebSocketChannelChild, etc.

Comment 4

[Jason Duell]

Attachment: Indent WebSocketChannel to match other classes

Re-indent WebsocketChannel. It's now or never--we don't want to do this after the Aurora branch.

Contains some cleanup of LOG msgs too.

Comment 5

[Jason Duell]

I've assigned these to Patrick, but there's actually no code logic changes here, so pretty much anyone can review.  I'd really like to land them before we fork for Aurora.  If anybody's got time to glance over them (just lots of class renaming) I'd appreciate it.

We don't have a backlog of WS patches right now, so patch breakage isn't an issue. The most "interesting" decision here is that we'll lose the hg blame for WebSocketChannel with the last, re-indent patch.  But the hg log is pretty short now, so I'm not seriously worried about it.

Comment 6

[Jason Duell]

http://hg.mozilla.org/integration/mozilla-inbound/rev/58c721a6bb1a
http://hg.mozilla.org/integration/mozilla-inbound/rev/0bfd2a8382c7
http://hg.mozilla.org/integration/mozilla-inbound/rev/3ebb4b775eee
http://hg.mozilla.org/integration/mozilla-inbound/rev/8df23f5d9709

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/58c721a6bb1a
http://hg.mozilla.org/mozilla-central/rev/0bfd2a8382c7
http://hg.mozilla.org/mozilla-central/rev/3ebb4b775eee
http://hg.mozilla.org/mozilla-central/rev/8df23f5d9709