664907 - Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Wu [:mwu]]

Attachment: Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds

Use MOZ_CHROME_FILE_FORMAT=symlink when omnijar is enabled.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 539969 [details] [diff] [review]
Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds

Review of attachment 539969 [details] [diff] [review]:
-----------------------------------------------------------------

This should be fine, although I'm slightly worried about the fact that we added hardlink support for Windows to JarMaker.py. In bug 574183 we hit some crazy MSYS bug that caused bad things to happen (see bug 642931). Maybe we should back out the JarMaker patch first?

Comment 2

[Michael Wu [:mwu]]

Attachment: Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds, v2

sid0 wasn't so sure that this would be safe either, so I'm making this only apply to non-windows.

Comment 3

[Mitchell Field [:Mitch]]

Comment on attachment 541883 [details] [diff] [review]
Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds, v2

The syntax looks fine to me. rs=Mitch

Comment 4

[Michael Wu [:mwu]]

http://hg.mozilla.org/projects/build-system/rev/6947bbce9672

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/6947bbce9672

Comment 6

[Matt Brubeck (:mbrubeck)]

Backed out during investigation of Android browser-chrome test failures:
http://hg.mozilla.org/mozilla-central/rev/00bb08972e46

Comment 7

[Michael Wu [:mwu]]

Attachment: Move *.properties comment stripping to staging

Comment 8

[Michael Wu [:mwu]]

Attachment: Don't link to self when dealing with files in the object directory

When using files in the current working directory, JarMaker.py uses '.' as the base directory, which ends up giving us links like bookmarks.json -> ./bookmarks.json . This replaces '.' with the actual working directory to give us proper symlinks.

Comment 9

[Michael Wu [:mwu]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d6fe12d237b0
http://hg.mozilla.org/integration/mozilla-inbound/rev/dd550792ca90
http://hg.mozilla.org/integration/mozilla-inbound/rev/95eda84ea6ba

Comment 10

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/d6fe12d237b0
http://hg.mozilla.org/mozilla-central/rev/dd550792ca90
http://hg.mozilla.org/mozilla-central/rev/95eda84ea6ba

Comment 11

[Aki Sasaki (not active)]

This may have broken Android multilocale builds.

Comment 12

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #11)
> This may have broken Android multilocale builds.

Verified; this broke Android multilocale builds.
https://bugzilla.mozilla.org/show_bug.cgi?id=674830#c32

(In reply to Marco Bonardo [:mak] (Away 8-14 Aug) from comment #10)
> http://hg.mozilla.org/mozilla-central/rev/d6fe12d237b0
> http://hg.mozilla.org/mozilla-central/rev/dd550792ca90
> http://hg.mozilla.org/mozilla-central/rev/95eda84ea6ba

Please back these out.

Comment 13

[Michael Wu [:mwu]]

(In reply to Aki Sasaki [:aki] from comment #12)
> Please back these out.

Gonna make a patch to disable this on android, h/o.

Comment 14

[Michael Wu [:mwu]]

Attachment: Exclude android

Probably won't be around to commit this patch.

Comment 15

[Steffen Wilberg]

Please either land attachment 551944 [details] [diff] [review] as a bustage fix, even if review is still pending, or back out the changesets mentioned in comment 12.

Firefox Mobile is completely broken because of this, see bug 674830.

Comment 16

[Michael Wu [:mwu]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1d071e2fa07f

Comment 17

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 551944 [details] [diff] [review]
Exclude android

Bookkeeping at this point, but r=me.

Comment 18

[Matt Brubeck (:mbrubeck)]

Android fix landed on m-c for Firefox 8:
https://hg.mozilla.org/mozilla-central/rev/1d071e2fa07f

Comment 19

[Aaron Train [:aaronmt]]

(In reply to Matt Brubeck (:mbrubeck) from comment #18)
> Android fix landed on m-c for Firefox 8:
> https://hg.mozilla.org/mozilla-central/rev/1d071e2fa07f

Verified Fixed the locale bustage
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110813 Firefox/8.0a1 Fennec/8.0a1