Closed
Bug 665051
Opened 13 years ago
Closed 13 years ago
branch filter worse than useless
Categories
(Tree Management Graveyard :: OrangeFactor, defect, P1)
Tree Management Graveyard
OrangeFactor
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(2 files)
827 bytes,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
7.63 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Ever since we put a "tree" filter in the top-left, the "branch" filter (in the orange filter box) has had ambiguous meaning. "branch", if provided, will trump "tree"; however, "branch" is only sent to the JSON APIs if it or any other orange-box filter is selected. So you get very funny results if you, say, set the build type to "opt". Now the calls to /bybug will have "branch=All", so the results will include all branches, regardless of the "tree" setting in the top left! This results in *more* test runs being displayed in the filtered data than in the overall data, which is totally confusing. Easy fix though: we'll completely remove the "branch" filter. The selected branch will always be the top-left tree filter, both in overall and in filtered results.
Comment 1•13 years ago
|
||
This is an easy fix on the server side.
Attachment #540097 -
Flags: review?(mcote)
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 540097 [details] [diff] [review] woo_server.py patch v0.1 Much better.
Attachment #540097 -
Flags: review?(mcote) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Client side. Also simple. I also increased the width of the QuickSearch and by ID filter text-entry boxes because it is now more noticeable that they are strangely short, compared to the width of the whole filter div. They look okay here now; lemme know if it looks okay for you (it *shouldn't* wrap to a separate line from the filter-type dropdown).
Attachment #540115 -
Flags: review?(jgriffin)
Comment 4•13 years ago
|
||
Comment on attachment 540115 [details] [diff] [review] Remove branch filter Looks good, and the new filter field widths look good also.
Attachment #540115 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Pushed as http://hg.mozilla.org/automation/orangefactor/rev/c26e04b264fc
Comment 6•13 years ago
|
||
Server-side patch pushed as http://hg.mozilla.org/automation/orangefactor/rev/6519361611d2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Testing → Tree Management
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•