665290 - Switch suite/mailnews to use Services.urlFormatter

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: suite switch to Services.urlFormatter

We import Services.jsm but we need to make better use of the urlFormatter provided by it.
This patch:
* Switches suite code to use urlFormatter provided by Services.jsm
* Does some code simplification around downloading dictionaries.

Comment 1

[[e-mail]]

Comment on attachment 540238 [details] [diff] [review]
suite switch to Services.urlFormatter

Nice, but could you move the try/catch into goDictionaryDownload too?

Comment 2

[Ian Neal]

Attachment: suite switch to Services.urlFormatter with try catch

Changes since last version:
* Moved try/catch to goDictionaryDownload helper
* Removed now unneeded addDictionary function and just call goDictionaryDownload directly from context menu.

Comment 3

[[e-mail]]

Comment on attachment 540315 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch

>diff --git a/editor/ui/dialogs/content/EdSpellCheck.js b/editor/ui/dialogs/content/EdSpellCheck.js
I just thought... Does Thunderbird use this dialog?

>diff --git a/suite/mailnews/compose/prefs/pref-composing_messages.js b/suite/mailnews/compose/prefs/pref-composing_messages.js
> function SelectLanguage(aTarget) {
>   try {
Nit: overlooked this try/catch.

Comment 4

[Ian Neal]

Attachment: suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

Changes since last version:
* Renamed helper to openDictionaryList to match TB so EdSpellCheck.js will work for them.
* Removed missed try/catch.

Comment 5

[[e-mail]]

Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

Nice of Thunderbird to make things easy for you :-)

Comment 6

[Ian Neal]

Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

To review impact of EdSpellCheck.js change.

Comment 7

[Ian Neal]

Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

Whoever can review the EdSpellCheck.js changes first.

Comment 8

[Ian Neal]

Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

http://hg.mozilla.org/comm-central/rev/0a3c60c01adf