665398 - Invalid Global called in dangerous manner when submitting XPI

Status: RESOLVED DUPLICATE of bug 665046

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mike Kaply [:mkaply]]

When I uploaded my TrackerBlock add-on, I got this warning:

Global called in dangerous manner
Warning: Synchronous HTTP requests can cause serious UI performance problems, especially to users with slow network connections.
modules/AdNetworks.jsm

    request.overrideMimeType("application/json");
    request.open("GET", "chrome://privacychoice/content/adnetworks/networks.json");

XMLHTTPRequest default to async, not sync so if there is no false parameter, this warning is unnecessary:

See:

https://developer.mozilla.org/En/NsIXMLHttpRequest#open()

Comment 1

[David Chan [:dchan]]

Attachment: proposed patch

Changing logic check in XHR test to only apply if there are > 2 arguments and the 3rd argument is false