Closed
Bug 665502
Opened 13 years ago
Closed 13 years ago
tabItems are resized when closing the active tab in a group
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 7
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
3.17 KB,
patch
|
dietrich
:
review+
raymondlee
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #540434 -
Flags: feedback?(raymond)
Comment 3•13 years ago
|
||
Comment on attachment 540434 [details] [diff] [review] patch v1 >+ win.gBrowser.loadOneTab("about:blank", {inBackground: true}); Why isn't this just win.gBrowser.addTab();?
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to comment #3) > >+ win.gBrowser.loadOneTab("about:blank", {inBackground: true}); > > Why isn't this just win.gBrowser.addTab();? Because that would add a new tab and make it the selectedTab, right? I wanted the first tab to stay selected.
Comment 5•13 years ago
|
||
(In reply to comment #4) > (In reply to comment #3) > > >+ win.gBrowser.loadOneTab("about:blank", {inBackground: true}); > > > > Why isn't this just win.gBrowser.addTab();? > > Because that would add a new tab and make it the selectedTab, right? Nope, addTab never does that.
Assignee | ||
Comment 6•13 years ago
|
||
Replaced gBrowser.loadOneTab() with gBrowser.addTab()
Attachment #540434 -
Attachment is obsolete: true
Attachment #540434 -
Flags: feedback?(raymond)
Attachment #540438 -
Flags: feedback?(raymond)
Comment 7•13 years ago
|
||
Comment on attachment 540438 [details] [diff] [review] patch v2 Looks good!
Attachment #540438 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #540438 -
Flags: review?(dietrich)
Comment 8•13 years ago
|
||
Comment on attachment 540438 [details] [diff] [review] patch v2 Review of attachment 540438 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #540438 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 9•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f7a2b52a76fd
Whiteboard: [inbound]
Comment 10•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f7a2b52a76fd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
Comment 11•13 years ago
|
||
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110626 Firefox/7.0a1 Verified on Ubuntu 11.04 x86, Mac OS X 10.6, Win 7 x86, Win XP using the following steps: 1. Open several tabs 2. Enter Panorama 3. Close the focused tab and observe the other tabs. Issue is no longer reproducible. Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•