Closed
Bug 665546
Opened 13 years ago
Closed 13 years ago
Fix unused variable warning in nsMediaStream.cpp
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 1 obsolete file)
|
1.51 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
content/media/nsMediaStream.cpp:334:16: warning: unused variable 'rv' http://mxr.mozilla.org/mozilla-central/source/content/media/nsMediaStream.cpp#334
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #540469 -
Flags: review?(roc)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 540469 [details] [diff] [review] Fix build warning Please use DebugOnly instead. See http://mxr.mozilla.org/mozilla-central/source/netwerk/ipc/NeckoMessageUtils.h#110 for an example.
Attachment #540469 -
Flags: review?(roc) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Updated patch that uses DebugOnly instead of #ifdef DEBUG.
Attachment #540469 -
Attachment is obsolete: true
Attachment #540480 -
Flags: review?(roc)
Comment on attachment 540480 [details] [diff] [review] Fix build warning v2 Review of attachment 540480 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #540480 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1ea90ba9d998
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•