665549 - Fix unused variable warning for 'shutdownObserved' in mozStorageService.cpp

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Ed Morley [:emorley]]

storage/src/mozStorageService.cpp:296:8: warning: unused variable 'shutdownObserved'

http://mxr.mozilla.org/mozilla-central/source/storage/src/mozStorageService.cpp#296

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove unused variable

Comment 2

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 540478 [details] [diff] [review]
Remove unused variable

This was added specifically so the assertion was more clear.  I'd rather see a patch to make shutdownObserved be a DebugOnly<bool> instead.

Comment 4

[Ed Morley [:emorley]]

Attachment: DebugOnly shutdownObserved

No worries, almost did it this way to start with, oh well! :-)

Thanks!

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 540994 [details] [diff] [review]
DebugOnly shutdownObserved

>+#include "mozilla/Util.h" // for DebugOnly
nit: lose the comment afterwards

r=sdwilsh

Comment 6

[Ed Morley [:emorley]]

Attachment: DebugOnly shutdownObserved

Only change is adjusted comment per above, carrying forwards r+.

Comment 7

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/dac5cae65da3

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/dac5cae65da3