665562 - Report Process / filter type (browser/plugin) doesn't seem to have an effect

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

(Thanks to Kairo for the find!)

STR:

1. Load https://crash-stats.allizom.org/query
2. Under "Report Process", choose either "Browser" or "Plugins Only"
3. Click Filter Crash Reports

Expected Results:

Only the respective browser or plugin crashes show

Actual Results:

This filter criteria doesn't appear to have an impact on results

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

This is a known bug, I did not implement it (because I did not have enough time, and because we don't have the data needed in ES). 

@Kairo: can it wait for 2.1 to be released?

Comment 2

[Robert Kaiser]

(In reply to comment #1)
> @Kairo: can it wait for 2.1 to be released?

Not really. We need this switch in queries we need to evaluate betas, etc.

The more detailed search in plugin names that it opens up should probably be hidden in UI if it doesn't work, but that can wait for 2.1 - the process_type selection should really not be broken in any release.

Comment 3

[Daniel Einspanjer [:dre] [:deinspanjer]]

What data is missing in ES exactly?

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Fix for bug 665562

* Implement process_type in ElasticSearch search
* Hide unused fields in the UI when ES is used in the middleware
* Add a new configuration key in webserviceclient.php ('middleware_implementation')

Comment 5

[Robert Helmer [:rhelmer]]

Comment on attachment 541445 [details] [diff] [review]
Fix for bug 665562

Seems fine; have you looked into what it would take to support this though? 

I can help track down how the data is getting into postgres, if you let me know what's missing from ES right now, and we should be able to figure out a way to get it there.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

This has a temporary fix for 2.0, pushing to 2.1 where it will have to be actually fixed.

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

This bug is resolved, what remains will be part of bug 678096.

Comment 8

[Matt Brandt [:mbrandt]]

QA verified, the respective browser or plugin crashes show when filtering on them under advanced search.