Closed Bug 665579 Opened 13 years ago Closed 13 years ago

Merge nsIThreadInternal and nsIThreadInternal2

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 1 obsolete file)

Patch, v1.1
7.17 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review
Attached patch Patch, v1 (obsolete) — — Splinter Review 
This interface was temporary, can be merged now.

It should be ok to keep the iid of nsIThreadInternal2, right?
Attachment #540496 - Flags: review?(benjamin)
Attachment #540496 - Flags: review?(benjamin) → review+
(In reply to comment #0)
> It should be ok to keep the iid of nsIThreadInternal2, right?

Ugh, seriously? Please don't do that.
Hrm, it's technically ABI-compatible, but really I don't see why you wouldn't bump it to a new IID (that's what I assumed the patch did).
I don't see why it's a bad thing... But I can bump it if it offends. Verdict?
bump it
Attached patch Patch, v1.1 — — Splinter Review 
Bumped.
Assignee: nobody → bent.mozilla
Attachment #540496 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #541759 - Flags: review+
Attachment #540496 - Flags: checkin?
http://hg.mozilla.org/mozilla-central/rev/94a77bde744b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: