Closed
Bug 665622
Opened 13 years ago
Closed 13 years ago
Fix unused variable warnings in GLContext.cpp & GLContextProviderEGL.cpp
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
VERIFIED
FIXED
mozilla7
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning][inbound])
Attachments
(1 file)
3.36 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
gfx/thebes/GLContext.cpp:1780:16: warning: unused variable 'status' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContext.cpp#1780 gfx/thebes/GLContextProviderEGL.cpp:1770: warning: unused variable 'context' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1770 gfx/thebes/GLContextProviderEGL.cpp:2168: warning: unused variable 'context' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#2168 gfx/thebes/GLContextProviderEGL.cpp:2169: warning: unused variable 'config' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#2169
Assignee | ||
Comment 1•13 years ago
|
||
For the GLContext.cpp change, I'm wondering whether the whole |fCheckFramebufferStatus(LOCAL_GL_FRAMEBUFFER)| line can be put inside an #ifdef DEBUG block, since it would seem that the call isn't required at all, since it does nothing other than check the status. Or does it still need to be called? If the call isn't needed, is there a DebugOnly macro for the whole line (as opposed to just the variable), or do I just fall back to #ifdef DEBUG? Thanks :-)
Attachment #540534 -
Flags: review?(joe)
Assignee | ||
Comment 2•13 years ago
|
||
http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068
Updated•13 years ago
|
Attachment #540534 -
Flags: review?(joe) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Joe, thanks for the quick review :-) Just wanted to double check before I mark this checkin-needed, that comment 1 didn't apply? Thanks!
Comment 4•13 years ago
|
||
Better to keep it for now.
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/093d1650e7a7
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/093d1650e7a7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Comment 7•13 years ago
|
||
Verified that the following files were updated in mozillla-central repository: gfx/thebes/GLContext.cpp gfx/thebes/GLContextProviderEGL.cpp Is this enough to verify the fix and mark the bug accordigly (VERIFIED-FIXED)? Thank you!
Comment 8•13 years ago
|
||
Yup, I'd say so. Setting to VERIFIED based on comment 7. Thanks!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•