Closed Bug 665772 Opened 13 years ago Closed 13 years ago

Malformed Multinames can throw in different locations in Verbose builds

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stejohns, Assigned: stejohns)

Details

Attachments

(1 file)

Minor, but: ifdef VERBOSE code in AbcParser will process a Multiname even if verbose mode is not enabled at Runtime. If the Multiname is malformed, it will throw here during parsing in Verbose builds, but not until much later in non-Verbose builds; we should move the parse to be done only if the verbose runtime flag is set, to minimize debugging differences between builds.
Attached patch PatchSplinter Review
Assignee: nobody → stejohns
Attachment #540606 - Flags: superreview?
Attachment #540606 - Flags: review?
Attachment #540606 - Flags: superreview?(edwsmith)
Attachment #540606 - Flags: superreview?
Attachment #540606 - Flags: review?(rreitmai)
Attachment #540606 - Flags: review?
Attachment #540606 - Flags: review?(rreitmai) → review+
tr 6406:e811339f8a76
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #540606 - Flags: superreview?(edwsmith) → superreview+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: