665816 - nsGlueLinkingDlopen.cpp:161: error: expected unqualified-id before numeric constant with NDKr5 after landing bug 632404

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Makoto Kato [:m_kato]]

Now tinderbox uses gcc 4.4.0 in NDK R4, but mobile team has a plan to upgrade to NDK R5.

Comment 1

[Makoto Kato [:m_kato]]

Also, there is no readahead function in NDK.

Comment 2

[Mike Hommey [:glandium]]

Would the NDK r5 happen to define ELFCLASS through elf.h ?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to comment #2)
> Would the NDK r5 happen to define ELFCLASS through elf.h ?

It is same as NDKr4.  But gcc 4.4.3 into NDKr5 defines __linux__ / linux as default.

when using NDKr4, LINUX is undefined during compiling this, so it can be compiled.  But when using NDKr5, LINUX is defined, so this error occurs.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 5

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8924b0de1365

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/8924b0de1365