665848 - [ACR] Automatically detect the version of the application to disable compatibility checks

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Updating the list of preferences to disable the compatibility checks for each specific version of the application is time consuming and will end-up in a huge list of preferences, as long as we do not remove old ones.

We should better automatically detect the version of Firefox and set such prefs automatically. With that code we never would have to worry again to update those prefs for a new application version.

The only problem I can see here, where would we have to inject this code? It probably already has to happen during start-up so we do not disable add-ons for the compatibility check. Dave, do you have an idea?

Comment 1

[Brian King [:kinger]]

(In reply to comment #0)
> The only problem I can see here, where would we have to inject this code? It
> probably already has to happen during start-up so we do not disable add-ons
> for the compatibility check. Dave, do you have an idea?

Note we already require a 2nd restart for incompatible add-ons to be enabled. See bug 572322.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I talk about compatibility checks between application version changes, not for the first time ACR gets installed.

Comment 3

[Dave Townsend [:mossop]]

I can't really think of a way to make this work. By design extensions shouldn't be able to do anything till the extension manager has finished its work, by which point it is too late to make the changes you want without a restart.

I guess one option for automatic updates would be to check the update manager on shutdown and see if a new update is pending and set the pref at that point.

Made a comment in bug 572322 for something I just remembered

Comment 4

[Brian King [:kinger]]

I don't think this is relevant anymore. We don't set prefs anymore in compat-by-default builds, and our hard-coded prefs cover all builds up to then.

Comment 5

[David McNamara [:mackers]]

Yes, there is no need to address this anymore as there will be no more extensions.checkCompatibility.x prefs.