666068 - Avoid calling UsingEffectsForFrame() on SVG content

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

On the SVG rotating tiger we spend about 0.9% of the time in UsingEffectsForFrame() which always returns false for svg content. We could avoid calling this by hanging a flag on the frame that would mark whether we are an SVG frame or not.

Comment 1

[(no longer active)]

I'm actually pretty surprised that we don't have this flag already.  It may also be useful in other pieces of our generic layout code where we do SVG specific hacks.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Where are we calling it from?  Invalidation, or something else?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #2)
> Where are we calling it from?  Invalidation, or something else?

Invalidation.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So bug 614732 might get us that "for free".

Comment 5

[Jonathan Watt [:jwatt]]

Sounds like it's just a case of adding an |frame->IsFrameOfType(nsIFrame::eSVG)| check. Either that or wait to see if bug 614732 or its followups fix this as bz says.

Comment 6

[Robert Longson [:longsonr]]

Should we just reorder the UsingEffectsForFrame() method in nsSVGIntegrationUtils so that it checks for a SVG frame first rather than last?

Comment 7

[Robert Longson [:longsonr]]

Attachment: like so?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 541060 [details] [diff] [review]
like so?

IsFrameOfType is still going to be a virtual call, but this patch seems like pure win.

Comment 9

[Robert Longson [:longsonr]]

Attachment: hg changeset patch

Comment 10

[(no longer active)]

Landed on inbound.

Comment 11

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/7bb02cc447e0