Closed
Bug 666135
Opened 13 years ago
Closed 13 years ago
Disable -Wcast-align when building with clang
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: craig.topper, Assigned: craig.topper)
References
Details
Attachments
(1 file)
|
5.53 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The -Wcast-align flag causes clang to print a lot of warnings. Bug 662971, bug 662969, bug 662964, bug 662962, and bug 662961 have been filed to fix some of these. A better solution is to just disable the flag when building with clang. It is already disabled on other platforms and compilers due to the amount of warnings it causes in those cases. See bugs 411292, bug 436133, and bug 557758.
|
Assignee | |
Updated•13 years ago
|
Blocks: clang-macosx
|
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #540979 -
Flags: review?(ted.mielczarek)
|
||
Updated•13 years ago
|
Assignee: nobody → craig.topper
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 540979 [details] [diff] [review] Disable -Wcast-align when building with clang Review of attachment 540979 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +1581,1 @@ > # Don't use -Wcast-align with ICC Can you fix the comment here to mention clang too? @@ +1631,1 @@ > # Don't use -Wcast-align with ICC Here as well.
Attachment #540979 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Pushed to inbound with the comment fixed in both configure.in files
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0c259dad48ac
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•