Closed Bug 666165 Opened 13 years ago Closed 13 years ago

Validator: Pollution from implicit global variable declarations from within functions not caught

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Product:
addons.mozilla.org Graveyard
Component:
Developer Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Q3 2011

People

(Reporter: nmaier, Assigned: basta)

Details

(Whiteboard: [ReviewTeam]) 

When implicitly declaring variables within a function (forgetting let/var) the variable will be created within the global scope and "pollute" it.

Failing test for this:
https://github.com/nmaier/amo-validator/commit/99b03f5791a9df244944ef909fab7ec621c428c9
Priority: -- → P3
Whiteboard: [required amo-editors]
Target Milestone: --- → Q3 2011
Merged:

https://github.com/mozilla/amo-validator/commit/2d874e862b889c491a2fb7f67839b77a9e6c8008
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.