666203 - Progress bars on Windows Classic need a padding

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Mounir Lamouri (:mounir)]

It looks like GetWidgetPadding doesn't work for Windows Classic. We should probably write a ClassicGetWidgetPadding.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Firefox progress bar

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Progress bar in Security Essentials

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Progress bar during security update

Comment 4

[Kai Liu]

Bug 661846 (currently awaiting checkin) will add a ClassicGetWidgetPadding function when it lands.

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to comment #4)
> Bug 661846 (currently awaiting checkin) will add a ClassicGetWidgetPadding
> function when it lands.

Awesome! I just pushed it to mozilla-inbound. That should make this bug a 3 line-patch ;)

Comment 6

[Mounir Lamouri (:mounir)]

Attachment: Add 1px padding for progress with the Classic theme

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/311835bfec30

Comment 8

[Valerio]

Mounir, can you take a look at Bug 661375? I think it requires a similar patch

Comment 9

[Vlad [QA]]

Hi guys.
Can you attach a testcase in order to verify this. 
Thanks.