666209 - Add method to check if a tab is an AppTab

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, enhancement)

Description

[Shriram (irc: Mavericks)]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

Include a method that returns a boolean value 
for pinned (tab.pinned) 
or unpinned state of Tab (tab.unpinned)


Reproducible: Always

Steps to Reproduce:
1. index = controller.length-1 or index = 0;
2. Use tabBrowser.getTab(index).pinned or tabBrowser.getTab(index).unpinned
3. Place it in controller.assert() or elsewhere

Actual Results:  
Gives an undefined value

Expected Results:  
Should return boolean value false or true 

Instead of accessing it as an attribute directly, 
a method pinned() or unpinned() on a tab will return appropriate boolean value

Should it be tab.pinned(), or tabBrowser.pinned( <indexOfTab> )

If not both, second one's preferable as manually retrieving of getting the Tab to
check the pinned or unpinned state of the tab is unncessary.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

This patch add the isAppTab method to the tabBrowser class, which simply requires the tab as parameter: tabBrowser.isAppTab(tabBrowser.getTab(0))

Because the whole implementation will change for the API refactoring I haven't created a test for this API addition.

Comment 2

[u279076]

(In reply to comment #1)
> Because the whole implementation will change for the API refactoring I
> haven't created a test for this API addition.

Could you use the patch on the blocked bug to test this API change?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's not a change, it's an addition. And I have tested this method, so I can say for sure it works.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 541057 [details] [diff] [review]
Patch v1

Looks fine. r+

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/378f235cb96c (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/72227ed4f874 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/49be853753fc (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/5980b8f5e4df (release)