666383 - [highlighter] make sure devtools.inspector.enabled is preffed off if not ready

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

With the landing of the new highlighter code in bug 642471, we need to make sure that the highlighter and inspector feature is ready for shipping. We should track this through the firefox 7 release and adjust the pref before merge as-needed.

Comment 1

[Johnathan Nightingale [:johnath]]

So, we're on aurora now. Rob - are we killing the inspector pref?

Comment 2

[Rob Campbell [:rc] (:robcee)]

Yes. Patch forthcoming.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Attachment: inspector disabled

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 546866 [details] [diff] [review]
inspector disabled

approved conditional on the positive review.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 546866 [details] [diff] [review]
inspector disabled

Seems like you need to adjust the comment too (i.e. just revert http://hg.mozilla.org/mozilla-central/rev/96c76749e35f#l1.1 )

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 546866 [details] [diff] [review]
inspector disabled

landed on aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/1b4168e307fb

Comment 7

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified issue on Win XP, Win 7, Mac OS X 10.6 and Ubuntu 11.04 - devtools.inspector.enabled is preffed off.

Setting resolution to VERIFIED FIXED.