Closed Bug 666475 Opened 13 years ago Closed 13 years ago

Intermittent browser_tabview_privatebrowsing.js | Test timed out

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 8

People

(Reporter: philor, Assigned: ttaubert)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

patch v2
4.23 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
There have been a few of these lately, but we've been calling them other random things.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308733545.1308735250.26021.gz
Rev3 Fedora 12x64 mozilla-central opt test mochitest-other on 2011/06/22 02:05:45
s: talos-r3-fed64-022

TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | we have 1 tab in private browsing
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | we have 1 group in private browsing
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | the tab is in the group
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | correct URL for private browsing
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Console message:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Test timed out
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attached patch patch v1 (obsolete) — — Splinter Review 

        Attachment #541330 -
        Flags: feedback?(raymond)

        Attachment #541330 -
        Flags: feedback?(raymond) → feedback+

    
    

    
  
Comment on attachment 541330 [details] [diff] [review]
patch v1

The fix is that we're now adding a tab without zooming right into it. We stay in tabview and therefore don't need to call showTabView(). The test timed out because we didn't wait for the tabview to be hidden before showing it again.

        Attachment #541330 -
        Flags: review?(ehsan)

    
  

        Attachment #541330 -
        Flags: review?(ehsan) → review+

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
backed out from mozilla-inbound because part of a push that increased number of random failures in Panorama browser-chrome tests.
Please reland in smaller chunks when ready.

    
  
Whiteboard: [orange], [inbound] → [orange]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
  
Depends on: 662812

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2
        — 
          — Splinter Review
      

    


  

        Attachment #541330 -
        Attachment is obsolete: true

        Attachment #541331 -
        Attachment is obsolete: true

        Attachment #544807 -
        Flags: review?(ehsan)

    
    

    
  
Comment on attachment 544807 [details] [diff] [review]
patch v2

>   // register a clean up for private browsing just in case
>   registerCleanupFunction(function() {
>-    pb.privateBrowsingEnabled = false;
>+    if (pb.privateBrowsingEnabled)
>+      pb.privateBrowsingEnabled = false;
>   });

You can just assign to false.  If we're out of PB mode, that would be a no-op.

r=me with that fixed.

        Attachment #544807 -
        Flags: review?(ehsan) → review+

    
    

    
      
  

    
    

    
      
  

    
    

    
  
http://hg.mozilla.org/integration/fx-team/rev/6f1affa4bb5e
Whiteboard: [orange] → [orange][fixed-in-fx-team]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/6f1affa4bb5e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 8

    
  
Blocks: bc-leaks

    
    

    
  
Prior to this patch, this test used to leak hundreds of windows, see bug 658738 comment 71. Does this make any sense?

    
    

    
  
Well, not hundreds, but about 139. Anyway, I would really like to know if the test was severely broken or if it revealed an issue that's still there but not exposed anymore.

    
  
No longer blocks: bc-leaks

    
    

    
  
Ignore my previous comments; bug 651643 killed the leaks, not this bug.
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: